Add ProtocolStart and GracefulClose messages #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardHinnant
suggested changes
May 12, 2021
gregtatcam
force-pushed
the
start-protocol
branch
from
0661f4a
to
cb45e40
Compare
HowardHinnant
approved these changes
May 17, 2021
SirJosh1987
approved these changes
Jun 9, 2021
SirJosh1987
approved these changes
Jun 9, 2021
SirJosh1987
approved these changes
Jun 9, 2021
gregtatcam
force-pushed
the
start-protocol
branch
2 times, most recently
from
b8e6bb2
to
ddf1931
Compare
gregtatcam
force-pushed
the
start-protocol
branch
from
ddf1931
to
3135288
Compare
…on start. Add InboundHandoff class to complete HTTP handshake and instantiate inbound PeerImp. Add GracefulClose message to close a peer connection on an application level error.
the last message is graceful close or if aborted and close flag is set. Don't close right after sending graceful close.
[FOLD] Add required include for non-unity build. Make InboundHandoff non-copiable.
gregtatcam
force-pushed
the
start-protocol
branch
from
3135288
to
fdcb750
Compare
|
(notes: changes how servers communicate with each other; Nik will review later) |
intelliot
added
Request for Comments
Feature Request
|
@JoelKatz FYI - since this is an area of the code that hasn't been touched in many years, let me know if there is anything that needs to be further tested. @sophiax851 it would be useful to confirm that none of these changes have adverse performance impact. Thank you! |
|
I'll add an item in our queue to run a comparison test with the 1.12 baseline. @intelliot |
|
Thank you! This will be included in the next beta. If we find any issues with it, we can revert it as appropriate. |
|
note: we should check with @nbougalis on whether this should be kept in |
8 tasks
8 tasks
intelliot
added
the
Reverted
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Clean up the peer-to-peer protocol start/close sequences by introducing START_PROTOCOL and GRACEFUL_CLOSE messages, which sync inbound/outbound peer send/receive. The GRACEFUL_CLOSE message differentiates application and link layer failures. * Introduce the `InboundHandoff` class to manage inbound peer instantiation and synchronize the send/receive protocol messages between peers. * Update `OverlayImpl` to utilize the `InboundHandoff` class to manage inbound handshakes. * Update `PeerImp` for improved handling of protocol messages. * Modify the `Message` class for better maintainability. * Introduce P2P protocol version `2.3`.
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
…PLF#3839)" (XRPLF#4850) This reverts commit 8f89694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add InboundHandoff class to send HTTP response
to the outbound peer and instantiate inbound PeerImp
when the response is sent. The peer then waits for
mtSTART_PROTOCOL message from the connected
outbound peer. When the message is received, the peer starts
sending the protocol messages. This update ensures that
the inbound peer is created once the overlay is established,
eliminating the need for doAccept(). In addition it synchronizes
send/receive protocol messages between the peers on start,
eliminating the need for copying the read buffer into the outbound
peer constructor.
Add mtGRACEFUL_CLOSE message to differentiate application
and link layer failures.
Type of Change